Should work fine, but I would replace the 12A circuit breaker going to the light with a ceramic fuse, and add a cool 12v 20a toggle switch. https://www.amazon.com/Nilight-90014E-Rocker-Toggle-Warranty/dp/B07QKFD7Z7/ref=sr_1_3?crid=22TXLXXCSKSF&keywords=automotive+switch&qid=1656374950&sprefix=automotive+switc%2Caps%2C86&sr=8-3
You should have another fuse between the battery and the Ebike controller (unless the controller has one built in).
Also I'm not sure what you are bolting the Ferrule to, but you should take a look at Bus Bars for connecting everything together. Most can be bolted directly to metal frames, and they keep everything neat and organized.
Does the Ebike controller act as a battery charger, or are you using something else for that? I'm assuming you have LIPO batteries, so you might want to isolate the Ebike controller with a switch when charging, due to you needing a higher voltage differential. It might not be good for the Ebike controller to have a higher voltage feeding into it. If the controller has a built in battery charger, then there's no need for this.
Also note: you probably would have gotten more support from r/ElectricalEngineering because this is electrical related. But you should add a link to what Ebike controller you are using, and battery for better support.
Looks like a standard slide switch. If you measure its dimensions you can probably find a close enough match on amazon
Or you could take the awesome option and replace it with one of these: https://www.amazon.com/Nilight-90014E-Rocker-Toggle-Warranty/dp/B07QKFD7Z7/ref=sr_1_4